Skip to content

[easy] Add comment on non-existent namespace/table at drop #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025
Merged

[easy] Add comment on non-existent namespace/table at drop #1245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/iceberg/src/catalog/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ pub trait Catalog: Debug + Sync + Send {
properties: HashMap<String, String>,
) -> Result<()>;

/// Drop a namespace from the catalog.
/// Drop a namespace from the catalog, or returns error if it doesn't exist.
async fn drop_namespace(&self, namespace: &NamespaceIdent) -> Result<()>;

/// List tables from namespace.
Expand All @@ -83,7 +83,7 @@ pub trait Catalog: Debug + Sync + Send {
/// Load table from the catalog.
async fn load_table(&self, table: &TableIdent) -> Result<Table>;

/// Drop a table from the catalog.
/// Drop a table from the catalog, or returns error if it doesn't exist.
async fn drop_table(&self, table: &TableIdent) -> Result<()>;

/// Check if a table exists in the catalog.
Expand Down
Loading