Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI FIx] Use Docker Compose V2 #575

Merged
merged 2 commits into from
Apr 3, 2024
Merged

[CI FIx] Use Docker Compose V2 #575

merged 2 commits into from
Apr 3, 2024

Conversation

HonahX
Copy link
Contributor

@HonahX HonahX commented Apr 3, 2024

Fixes #574

Fokko
Fokko approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking into this as well :D Thanks for the quick turnaround!

@Fokko
Copy link
Contributor

Fokko commented Apr 3, 2024

@HonahX Seem to be a few more in ./dev/run-{azurite,gcs-server,minio}.sh

@HonahX
Copy link
Contributor Author

HonahX commented Apr 3, 2024

@Fokko Thanks for the quick review! I updated all remaining docker-compose to docker compose

@HonahX HonahX merged commit 474b37b into apache:main Apr 3, 2024
7 checks passed
@Fokko
Copy link
Contributor

Fokko commented Apr 3, 2024

Thank you for the PR @HonahX 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Workflows Fail because Docker Compose v1 support is removed
2 participants
@HonahX @Fokko