Fix CommitTableRequest serialisation #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 14, 2024 17:29
Fokko
approved these changes
Mar 17, 2024
There was a problem hiding this comment.
This looks great @kdbhiggins, and also nice that this gets rid of SerializeAsAny
Fokko
pushed a commit
to Fokko/iceberg-python
that referenced
this pull request
Mar 28, 2024
* add failing test * make requirements a discriminated union * use discriminated type union * add return type * use type annotation * have requirements inherit from ValidatableTableRequirement * AddSortOrder filter by type * lint --------- Co-authored-by: Kieran Higgins <[email protected]>
Fokko
pushed a commit
to Fokko/iceberg-python
that referenced
this pull request
Mar 28, 2024
* add failing test * make requirements a discriminated union * use discriminated type union * add return type * use type annotation * have requirements inherit from ValidatableTableRequirement * AddSortOrder filter by type * lint --------- Co-authored-by: Kieran Higgins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered an error when trying to deserialize the
CommitTableRequestobject.raises
TypeError: Can't instantiate abstract class TableRequirement with abstract method validateI added a test to round-trip serialize/deserialize the
CommitTableRequest. After investigating I was able to fix it by using Discriminated Unions, which seem like a natural fit for theTableUpdateandTableRequirement.