Accept pyarrow LargeListType and FixedSizeListType #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
commented
Feb 20, 2024
Fokko
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Looks good @hussein-awala Thanks for adding the support for the different lists. Thanks @HonahX for the review 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #451
The C++ implementation of Arrow has different types of lists (https://arrow.apache.org/docs/cpp/api/datatype.html#_CPPv4N5arrow12BaseListTypeE), but these types are not correctly implemented in Python, where there is no common superclass for them, they extend the DataType class directly.
LargeListTypeandFixedSizeListTypeare also lists but with some extra characteristics, so they should be accepted by PyIceberg, and transformed to ListType as the PyArrowListType.In the mentioned issue, PyArrow map the Polars list to a
LargeListTypeinstead ofListTypeand that's why it fails.