Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the snapshot creation part of the Transaction #446

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 19, 2024

Add an UpdateSnapshot for constructing snapshots similar to the Java API, and the update schema API.

This is also how it is done in Java, and I really like it
since it allows you to easily queue up updates in a transaction.
For example, an update to the schema.
@Fokko Fokko added this to the PyIceberg 0.7.0 release milestone Feb 19, 2024
@HonahX HonahX self-requested a review February 19, 2024 23:44
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this @Fokko! May be in a follow-up PR: Shall we also add a new section in API to show examples of UpdateSnapshot?

@Fokko Fokko merged commit 015226d into apache:main Feb 20, 2024
6 checks passed
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Feb 20, 2024
* Make the snapshot creation part of the `Transaction`

This is also how it is done in Java, and I really like it
since it allows you to easily queue up updates in a transaction.
For example, an update to the schema.

* Extend the API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants