Fix downgrading of schema #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
HonahX
approved these changes
Dec 3, 2023
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the quick fix!
pyiceberg/table/__init__.py
Outdated
| existing_schema_id: Optional[int] = None | ||
| for schema in self._table.metadata.schemas: | ||
| if new_schema == schema: | ||
| existing_schema_id = schema.schema_id |
Contributor
There was a problem hiding this comment.
Shall we add a break here? Or may be:
existing_schema_id = next(
(schema.schema_id for schema in self.schemas if schema == new_schema), None)
Contributor
Author
There was a problem hiding this comment.
Oh, your suggestion is beautiful, thanks!
danielcweeks
approved these changes
Dec 4, 2023
Contributor
Author
|
Thanks @danielcweeks and @HonahX for the review 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.