Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move snapshot history expire table properties to constants #1217

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ndrluis
Copy link
Collaborator

@ndrluis ndrluis commented Oct 3, 2024

I will be opening some PRs that will make it possible to implement the expire snapshot procedure. To make it easier to review, I'm breaking it down into smaller PRs.

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM. I think we might need to go through the deprecation steps and mark the properties in console.py as deprecated.

Similar to https://github.com/apache/iceberg-python/pull/1151/files#diff-23e8153e0fd497a9212215bd2067068f3b56fa071770c7ef326db3d3d03cee9bR1485-R1491

@ndrluis
Copy link
Collaborator Author

ndrluis commented Oct 4, 2024

@kevinjqliu, please take a look. I have tried many solutions, and this is the best I could come up with. The problem is that any import in this module triggers the deprecation message. The lesson I learned is to never have a constant at the module level. It’s better to namespace constants within classes, so we can deprecate them by simply creating a function as a property.

@kevinjqliu
Copy link
Contributor

oh no, sorry for making this more difficult than it should be :(
I think its okay to do this without the deprecation steps, but let's see what others think
cc @sungwy @HonahX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants