Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct spec when rewiting existing manifests #1157

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Sep 10, 2024

Fixes #1108

Copy link
Collaborator

@sungwy sungwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fokko ! It's great to see you again. Thank you for jumping in to fix this issue. The fix and the test looks good to me, I just have a nit suggestion about the name of the new test

tests/integration/test_writes/test_writes.py Outdated Show resolved Hide resolved
@sungwy sungwy merged commit 67e8773 into apache:main Sep 11, 2024
8 checks passed
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
* Use the correct spec when rewiting existing manifests

Fixes apache#1108

* Rename test
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
* Use the correct spec when rewiting existing manifests

Fixes apache#1108

* Rename test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when overwriting data with row filter
2 participants