Skip to content

RestCatalog with sigv4 enabled doesn't pick up creds provided as arguments #2070

@gruuya

Description

@gruuya

Feature Request / Improvement

SigV4Adapter doesn't use any of the s3.* properties provided to the catalog when instantiating a boto3 session, instead it always falls back on boto's credential chain resolution logic

class SigV4Adapter(HTTPAdapter):
def __init__(self, **properties: str):
super().__init__()
self._properties = properties
def add_headers(self, request: PreparedRequest, **kwargs: Any) -> None: # pylint: disable=W0613
boto_session = boto3.Session()
credentials = boto_session.get_credentials().get_frozen_credentials()

Related to #2069,

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions