ci(catalog/rest): initial framework for rest catalog integration tests #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
approved these changes
Feb 25, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
BTW theres a REST Compatibility Kit (RCK) apache/iceberg#10908 that can be run against a REST catalog to test its compatibility with the REST spec.
Fokko
approved these changes
Feb 26, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Looks good, and I agree that we need this :)
Member
Author
|
@kevinjqliu I'll definitely look into the RCK! thanks for suggesting it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought up by #291 we need to add some simple integration tests for the REST catalog to ensure that our requests and handling are correct according to the spec and not just according to our mocked request/responses.
This creates an initial framework for adding REST integration tests (more need to be added) which already discovered an issue in the delete requests that is also fixed by this PR.