Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Conversation

@nastra
Copy link
Contributor

@nastra nastra commented Jun 3, 2022

No description provided.

@@ -0,0 +1,6 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this file accidentally copied here? It causes hugo serve to fail and this should instead be in docs/archetypes/default.md (a copy already exists there).

@@ -0,0 +1,5 @@
---
Copy link
Contributor

@samredai samredai Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files shouldn't be in a nested content/docs/docs directory. All of the sections should be placed directly in content/docs. The file tree for content should look like this.

content
├── _index.md
└── docs
    ├── api
    │   ├── _index.md
    │   ├── java-api-quickstart.md
    │   ├── java-api.md
    │   ├── java-custom-catalog.md
    │   ├── javadoc
    │   │   └── _index.md
    │   ├── python-api-intro.md
    │   ├── python-feature-support.md
    │   └── python-quickstart.md
    ├── asf
    │   ├── _index.md
    │   ├── donate
    │   │   └── _index.md
    │   ├── events
    │   │   └── _index.md
    │   ├── license
    │   │   └── _index.md
    │   ├── security
    │   │   └── _index.md
    │   └── sponsors
    │       └── _index.md
    ├── athena
    │   └── _index.md
    ├── community
    │   ├── _index.md
    │   ├── blogs.md
    │   ├── contributing.md
    │   ├── join.md
    │   └── talks.md
    ├── dremio
    │   └── _index.md
    ├── emr
    │   └── _index.md
    ├── flink
    │   ├── _index.md
    │   ├── flink-connector.md
    │   └── flink-getting-started.md
    ├── format
    │   ├── _index.md
    │   ├── spec.md
    │   ├── terms.md
    │   └── view-spec.md
    ├── hive
    │   └── _index.md
    ├── integrations
    │   ├── _index.md
    │   ├── aws.md
    │   ├── jdbc.md
    │   └── nessie.md
    ├── prestodb
    │   └── _index.md
    ├── project
    │   ├── _index.md
    │   ├── benchmarks.md
    │   ├── how-to-release.md
    │   ├── how-to-verify-a-release.md
    │   ├── multi-engine-support.md
    │   ├── roadmap.md
    │   ├── security.md
    │   └── trademarks.md
    ├── releases
    │   ├── 0.12.1
    │   │   └── _index.md
    │   ├── 0.13.0
    │   │   └── _index.md
    │   ├── 0.13.1
    │   │   └── _index.md
    │   ├── 0.13.2
    │   │   └── _index.md
    │   ├── _index.md
    │   ├── latest
    │   │   └── _index.md
    │   └── release-notes.md
    ├── spark
    │   ├── _index.md
    │   ├── spark-configuration.md
    │   ├── spark-ddl.md
    │   ├── spark-getting-started.md
    │   ├── spark-procedures.md
    │   ├── spark-queries.md
    │   ├── spark-structured-streaming.md
    │   └── spark-writes.md
    ├── starrocks
    │   └── _index.md
    ├── tables
    │   ├── _index.md
    │   ├── configuration.md
    │   ├── evolution.md
    │   ├── maintenance.md
    │   ├── partitioning.md
    │   ├── performance.md
    │   ├── reliability.md
    │   └── schemas.md
    └── trino
        └── _index.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now

@@ -0,0 +1,54 @@
---
Copy link
Contributor

@samredai samredai Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file already exists in docs/content/_index.md and shouldn't need to be duplicated here. Changes can be made to the existing location and that will get updated as soon as the version branch is cut.

@samredai
Copy link
Contributor

samredai commented Jun 3, 2022

@nastra the extra docs directory is the root cause of the issues in the other comments. I'm realizing it's because this sentence in the instructions could be clearer and might have been interpreted as copying the directory :

  1. Copy the contents under docs in the iceberg repo to ./docs/content/docs in the release branch

That would be stated more clearly as:

  1. Copy the docs directory in the iceberg repo into ./docs/content/ in the release branch

See the tree structure in this comment. So for example the spark directory of markdown files should be docs/content/docs/spark, not docs/content/docs/docs/spark.

@nastra nastra force-pushed the 0.13.2-doc-updates branch from bb03121 to 378a636 Compare June 14, 2022 06:52
@nastra nastra changed the base branch from main to 0.13.2 June 15, 2022 13:53
Copy link
Contributor

@samredai samredai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nastra nastra force-pushed the 0.13.2-doc-updates branch from 378a636 to 91acd39 Compare June 15, 2022 16:23
@RussellSpitzer RussellSpitzer merged commit 461b9aa into apache:0.13.2 Jun 15, 2022
@nastra nastra deleted the 0.13.2-doc-updates branch June 20, 2022 07:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants