-
Notifications
You must be signed in to change notification settings - Fork 95
Add contribution guidelines #35
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,15 +26,59 @@ It's built with [Hugo](https://gohugo.io/) and hosted at https://iceberg.apache. | |
|
|
||
| The Iceberg documentation site is actually constructed from two hugo sites. The first, is the landing page. The second site, | ||
| is the documentation site which contains the full Iceberg documentation, including the javadoc. The landing page and | ||
| documentation sites are completely self-contained in the `./landing-page` and `./docs` directories, respectively. | ||
| documentation sites are completely self-contained in the `./landing-page` and `./docs` directories, respectively. The Javadocs are in the `./javadoc` directory. | ||
|
|
||
| # Landing Page Deployment | ||
| # How to Contribute | ||
|
|
||
| ## Submitting Pull Requests | ||
|
|
||
| All pull requests to update the latest documentations should be submitted to the [Iceberg repository](https://github.com/apache/iceberg). | ||
| When Iceberg publishes a new release, the release manager copies all the documentation to this repository and cut a new version branch. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/cut/cuts |
||
|
|
||
| Changes to the landing page should be submitted to this repository against the `main` branch. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The landing-page site includes the common markdown files as well (releases, spec, community, etc). We should keep those in
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes agree, forgot to update this sentence after updating the scripts |
||
|
|
||
| Changes to the documentation of old Iceberg versions should be submitted to this repository against the specific version branch. | ||
|
|
||
| ## Reporting Issues | ||
|
|
||
| All issues related to documentation and website should still be submitted to the [Iceberg repository](https://github.com/apache/iceberg). | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/to documentation and website/to the documentation website |
||
|
|
||
| ## Running Locally | ||
|
|
||
| To start the landing page site locally, clone this repository and run the following. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: the code block includes the clone so maybe just say "To start the landing page site locally, run the following."
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will move the |
||
| ```shell | ||
| git clone git@github.com:apache/iceberg-docs.git | ||
| cd landing-page && hugo serve | ||
| ``` | ||
|
|
||
| To start the documentation site locally, clone this repository and run the following. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: same comment about the clone already being included in the code block. |
||
| ```shell | ||
| git clone git@github.com:apache/iceberg-docs.git | ||
| git submodule update --init | ||
| cd docs && hugo serve | ||
| ``` | ||
|
|
||
| ## Viewing Latest Website | ||
|
|
||
| If you would like to see how the latest website looks based on the documentation in the Iceberg repository, you can copy docs to this repository by: | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. need to refine this workflow a bit, does the
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like there is another part in the
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. okay so I assume the iceberg repo would have a
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, exactly right. In
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Once this PR and PR #27 is merged, I'll go ahead and open the PR against
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. got it, let me update based on this info |
||
| ```shell | ||
| cp -r iceberg/documentation/* iceberg-docs/content/docs | ||
| ``` | ||
|
|
||
| ## Scanning For Broken Links | ||
|
|
||
| If you'd like to scan for broken links, one available tool is linkcheck that can be found [here](https://github.com/filiph/linkcheck). | ||
|
|
||
|
|
||
| # How the Website is Deployed | ||
|
|
||
| ## Landing Page Deployment | ||
|
|
||
| The landing page site is automatically deployed to the root of the `asf-site` branch by the `deploy-landing-page` | ||
| job in the [deployment workflow](./.github/workflows/deploy.yml). There is only a single version of the landing | ||
| page site, and the `deploy-landing-page` job only runs on commits to the `main` branch. | ||
|
|
||
| # Docs Deployment | ||
| ## Docs Deployment | ||
|
|
||
| The docs site is automatically deployed to the `docs` directory in the asf-site branch, into a sub-directory | ||
| named after the branch where the commit occured. This is performed by the `deploy-docs` job in the | ||
|
|
@@ -75,29 +119,10 @@ in the `asf-site` branch's `javadoc` directory. | |
| A `main` branch commit deploys the landing page site **only** and overwrites the landing page site at | ||
| the root of the `asf-site` branch. | ||
|
|
||
| # Redirects | ||
| ## Redirects | ||
|
|
||
| Redirects within one of the two sites can easily be done using the `aliases` keyword in the YAML Front Matter. | ||
| You can read more about this Hugo URL Management feature [here](https://gohugo.io/content-management/urls/#yaml-front-matter). | ||
|
|
||
| For root level redirects that are outside of both sites, the `./redirects` directory contains pages with redirect `meta` tags. | ||
| These are all deployed at the root level of the `asf-site` branch by the `Deploy redirects` step in the [deployment workflow](./.github/workflows/deploy.yml). | ||
|
|
||
| # Running Locally | ||
|
|
||
| To start the landing page site locally, clone this repository and run the following. | ||
| ``` | ||
| git clone git@github.com:apache/iceberg-docs.git | ||
| cd landing-page && hugo serve | ||
| ``` | ||
|
|
||
| To start the documentation site locally, clone this repository and run the following. | ||
| ``` | ||
| git clone git@github.com:apache/iceberg-docs.git | ||
| git submodule update --init | ||
| cd docs && hugo serve | ||
| ``` | ||
|
|
||
| # Scanning For Broken Links | ||
|
|
||
| If you'd like to scan for broken links, one available tool is linkcheck that can be found [here](https://github.com/filiph/linkcheck). | ||
| These are all deployed at the root level of the `asf-site` branch by the `Deploy redirects` step in the [deployment workflow](./.github/workflows/deploy.yml). | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved up contribution guide because readers are most likely interested in that