[HUDI-6702] Remove unnecessary calls of getInsertValue api from HoodieRecordPayload
#9572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linliu-code
force-pushed
the
extending_merger_api
branch
2 times, most recently
from
24e7acc to
7e769e6
Compare
danny0405
reviewed
Aug 30, 2023
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecord.java
Outdated
Show resolved
Hide resolved
linliu-code
force-pushed
the
extending_merger_api
branch
from
7e769e6 to
cf84844
Compare
linliu-code
changed the title
yihua
reviewed
Aug 30, 2023
| Option<Schema> schemaWithoutMetaFields) throws IOException { | ||
| IndexedRecord indexedRecord = (IndexedRecord) data.getInsertValue(recordSchema, props).get(); | ||
| HoodieAvroRecordMerger merger = HoodieAvroRecordMerger.INSTANCE; | ||
| HoodieAvroIndexedRecord record = (HoodieAvroIndexedRecord) merger.merge( |
Contributor
There was a problem hiding this comment.
Let's change the merge API to
Option<Pair<HoodieRecord, Schema>> merge(Option<HoodieRecord> older, Schema oldSchema, Option<HoodieRecord> newer, Schema newSchema, TypedProperties props)
so that we pass in Option.empty instead of null.
Collaborator
Author
There was a problem hiding this comment.
Yeah, will create a separate PR for this change.
yihua
reviewed
Aug 30, 2023
...hudi-client-common/src/main/java/org/apache/hudi/common/table/log/HoodieFileSliceReader.java
Outdated
Show resolved
Hide resolved
linliu-code
force-pushed
the
extending_merger_api
branch
from
cf84844 to
d6904d0
Compare
This task further removes the leftover of callings of `getInsertValue` from HoodieRecordPayload. Changes: 1. Add a function to HoodieMetadataPayload class to return HoodieMetadataRecord class. 2. Call this function from ColumnStatsIndices and ColumnStatsIndexSupport classes, instead of the `getInsertValue` function. Tests: Existing unit tests.
linliu-code
force-pushed
the
extending_merger_api
branch
from
d6904d0 to
93813ed
Compare
linliu-code
changed the title
getInsertValue api from HoodieRecordPayload
Collaborator
Author
|
@yihua @danny0405 please comment! Thank you! |
linliu-code
changed the title
getInsertValue api from HoodieRecordPayloadgetInsertValue api from HoodieRecordPayload
yihua
reviewed
Sep 5, 2023
| } catch (IOException e) { | ||
| throw new HoodieException("Exception while getting insert value from metadata payload"); | ||
| } | ||
| GenericRecord genericRecord = (GenericRecord) record.getData().toHoodieMetadataRecord().orElse(null); |
Contributor
There was a problem hiding this comment.
Given that this still calls the HoodieMetadataPayload APIs which implements HoodieRecordPayload, shall we keep these as is? Ideally, once we migrate the metadata payload to new merger API, these can be got rid of.
Collaborator
Author
There was a problem hiding this comment.
Yes, we can leave it as is. Sound like it will not block rfc-46. Will undo the change for it.
Collaborator
Author
There was a problem hiding this comment.
Just checked the files; if we leave it as is, then there is nothing to change for this PR.
Collaborator
Author
|
This issue should have been fixed together with PR: #9593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Impact
No impact on the functional side.
Risk level (write none, low medium or high below)
instead of the
getInsertValuefunction.TESTS:
Contributor's checklist