[HUDI-6624]Fix to return a empty list when there is no commit instant to read #9325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Aug 1, 2023
| metaClient.getCommitsAndCompactionTimeline().filterCompletedAndCompactionInstants(), fileStatuses); | ||
| if (!fsView.getLastInstant().isPresent()) { | ||
| throw new HoodieException("No completed instant found for table : " + conf.getString(FlinkOptions.TABLE_NAME)); | ||
| } |
Contributor
There was a problem hiding this comment.
Instead of throwing exception, can we returns a empty list so the query result is just empty?
hehuiyuan
force-pushed
the
master-describe-no-commit-instant
branch
from
b40ae1b to
5d1b0af
Compare
hehuiyuan
changed the title
hehuiyuan
changed the title
danny0405
approved these changes
Aug 1, 2023
Collaborator
zhangyue19921010
pushed a commit
to zhangyue19921010/hudi
that referenced
this pull request
Aug 31, 2023
…he#32) * [HUDI-6624] Fix to return Empty when there is no commit instant (apache#9325) * [HUDI-6358] Fix flink payload merger with deletes (apache#8935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
The exception is not clean enough, we can point out the exception.