[HUDI-6581] Remove unnecessary validations in function getOldestInstantToRetainForClustering #9265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Seems reasonable, @bvaradar can you help for double check this ~ |
Contributor
Author
|
@bvaradar could you help to review this pull request？ |
zhuanshenbsj1
force-pushed
the
pendingClustering
branch
from
ac48542 to
c9d04ea
Compare
Contributor
|
@zhuanshenbsj1 Can you rebase with the latest master and make the tests pass? |
zhuanshenbsj1
force-pushed
the
pendingClustering
branch
from
c9d04ea to
81fe0d5
Compare
Contributor
Author
|
@hudi-bot run azure |
danny0405
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR can sufficient to ensure the retention of the previous commit for first pending clustering, no need to check again.
(#8783)
Impact
none.
Risk level (write none, low medium or high below)
none.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist