Skip to content

Conversation

@parisni
Copy link
Contributor

@parisni parisni commented Jul 20, 2023

Change Logs

This makes the parquet bloom filter work correctly. After trying out the #8716 the bloom where not being created

  1. the reflexion usage was incorrect and this was silently doing nothing
  2. The reason is the test was not verifying correctly the bloom is created. A side effect of parquet stats was used in place of bloom in newer versions of parquet

This PR :

  1. fixes the impl
  2. fixes the test

Double check with parquet-cli after the patch confirmed the bloom exist. We cannot yet use such checks since only recent version of parquet can verify the bloom exist

Impact

Describe any public API or user-facing feature change or any performance impact.

Risk level (write none, low medium or high below)

If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@parisni
Copy link
Contributor Author

parisni commented Jul 20, 2023

@danny0405 may you take a look on this ?

Thanks !

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit 9d7b93f into apache:master Jul 21, 2023
@gsudhanshu
Copy link

hi @danny0405 @parisni ,

when would this feature be released?

Thanks & Regards,
Sudhanshu

@parisni
Copy link
Contributor Author

parisni commented Sep 21, 2023

@gsudhanshu from the jira tracker this should be in upcoming 0.14 version.

https://issues.apache.org/jira/browse/HUDI-6226

But I couldn't find the commit in the release. Not sure then

@gsudhanshu
Copy link

@parisni can you kindly escalate this and ensure that this commit comes in 0.14 v release

we need it, thanks

@parisni
Copy link
Contributor Author

parisni commented Sep 22, 2023 via email

@parisni
Copy link
Contributor Author

parisni commented Sep 22, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants