[HUDI-6543] Enhance OCC conflict detection #9233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zouxxyy
changed the title
4 tasks
Zouxxyy
changed the title
Collaborator
codope
reviewed
Jul 21, 2023
Member
There was a problem hiding this comment.
@Zouxxyy I am yet to review the patch fully. Just curious, why removing this strategy? Is it taken care of in the new conflict resolver based on state transition time?
Contributor
Author
There was a problem hiding this comment.
@Zouxxyy I am yet to review the patch fully. Just curious, why removing this strategy? Is it taken care of in the new conflict resolver based on state transition time?
Two reasons:
- If we want to use bucket index, ingestion primary, and don't want to use state transition time (because it is not stable yet), how to choose the strategy, should we write another one?
- I hope that the current strategy can automatically identify the bucket index and ingestion primary, which is better for users.
4 tasks
Zouxxyy
commented
Jul 22, 2023
| if (!isIngestionPrimaryClustering()) { | ||
| actionsToPick.add(REPLACE_COMMIT_ACTION); | ||
| } | ||
| actionsToPick.add(COMPACTION_ACTION); |
Contributor
Author
There was a problem hiding this comment.
Here I just keep the current implementation, because log compaction has pre commit now, hope to get more opinions @suryaprasanna
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
ConflictResolutionStrategyinterfaceSimpleConcurrentFileWritesConflictResolutionStrategyto automatically identify write priority or bucket index, and optimize the logic ofgetCandidateInstantsStateTransitionTimeBasedConflictResolutionStrategy, which is based on StateTransition and does not need to get pending instantslastCompletedTxnOwnerInstantinTransactionManager(only used for conflict detection, under the new logic, it has no effect)To know more, can read #9220
Impact
above
Risk level (write none, low medium or high below)
medium
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist