-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-6516] Correct the use of hoodie.bootstrap.mode.selector #9164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI failure is caused by other, Can you help with a review? @codope |
|
@danny0405 @codope Can someone help with a review? It's a bug fix, before it the usage and test cases of |
codope
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zouxxyy Can you tell me what scneario is fixed by this PR?
As per my understanding, hoodie.bootstrap.mode.selector can take one of three classnames:
BootstrapRegexModeSelectorMetadataOnlyBootstrapModeSelectorFullRecordBootstrapModeSelector
If that config is set toBootstrapRegexModeSelectorthenhoodie.bootstrap.mode.selector.regexis used (default value.*means all partitions).
And then there is a confighoodie.bootstrap.mode.selector.regex.modewhich can be eitherFULL_RECORDorMETADATA_ONLY. This config cannot be set toMETADATA_ONLYif we are usingFullRecordBootstrapModeSelector. The current logic seems to cover different scenarios. Are we missing a corner case?

Change Logs
The following is the current configuration of bootstrap's mode selection:
hoodie.bootstrap.mode.selectorhoodie.bootstrap.mode.selector.regexhoodie.bootstrap.mode.selector.regex.modeFix #6673 (comment), The correct use of
hoodie.bootstrap.mode.selectoris:set
hoodie.bootstrap.mode.selectorasBootstrapRegexModeSelector, specify partitions byhoodie.bootstrap.mode.selector.regex, then sethoodie.bootstrap.mode.selector.regex.modefor the specify partitionsset
hoodie.bootstrap.mode.selectorasMetadataOnlyBootstrapModeSelectororFullRecordBootstrapModeSelectorImpact
Correct the use of hoodie.bootstrap.mode.selector
Risk level (write none, low medium or high below)
low
Documentation Update
none
Contributor's checklist