Skip to content

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Jun 15, 2023

Change Logs

#7561 introduced a bug where in a case, the partition changes may be missed in the meta sync, e.g., the following active timeline:

ts3.rollback, ts50.commit, ts51.commit, ts52.commit, ...

and ts49.commit and ts48.commit are archived.

If ts47 is the last sync commit time, and ts48.commit or ts49.commit has partition changes, meta sync misses such changes.

This above issue is solved by a separate PR #8388 where the hive sync client returns the right timeline which gives write commits only for checking.

This PR makes sure the problematic API implementation (TimelineUtils.getCommitsTimelineAfter) is still fixed.

Existing tests are enhanced:

Impact

Fixes a bug.

Risk level

low

Documentation Update

We need to update release notes on the regression.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@yihua yihua added component:catalog-sync Catalog-sync related priority:critical Production degraded; pipelines stalled labels Jun 15, 2023
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit db741da into apache:master Jun 16, 2023
yihua added a commit to yihua/hudi that referenced this pull request Aug 24, 2023
…a sync (apache#8991)

This commit fixes the problematic API implementation (TimelineUtils.getCommitsTimelineAfter) introduced by apache#7561.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:catalog-sync Catalog-sync related priority:critical Production degraded; pipelines stalled

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants