[HUDI-6378] allow to delete twice for an empty table #8967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@KnightChess |
KnightChess
reviewed
Jun 14, 2023
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
Outdated
Show resolved
Hide resolved
...ark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestDeleteFromTable.scala
Outdated
Show resolved
Hide resolved
yihua
reviewed
Jun 15, 2023
| throw new HoodieIOException("Latest commit does not have any schema in commit metadata"); | ||
| } | ||
| } else { | ||
| String schemaStr = new TableSchemaResolver(metaClient).getTableAvroSchema().toString(); |
Contributor
There was a problem hiding this comment.
The whole method can be replaced by the new logic with try-catch block:
String schemaStr = new TableSchemaResolver(metaClient).getTableAvroSchema().toString();
config.setSchema(schemaStr);
Contributor
|
LGTM. @lvyanquan could you check the test failures? |
Contributor
Author
|
@hudi-bot run azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
delete operation will use schema of lastInstant.
Howerver, if last commit is deletion on an empty table, schema will be
""string, if we throw exception now, we could not execute idempotent deletion.Add a test for this situation.
relevant pr #5610
Impact
fix bug for deletion from an empty table.
Risk level (write none, low medium or high below)
low
Contributor's checklist