Skip to content

Conversation

@zhuanshenbsj1
Copy link
Contributor

Change Logs

Describe context and summary for this change. Highlight if any code was copied.

Impact

Describe any public API or user-facing feature change or any performance impact.

Risk level (write none, low medium or high below)

If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

Copy link
Contributor Author

@zhuanshenbsj1 zhuanshenbsj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

byte[] data = timelineBeforeCurrentCompaction.getInstantDetails(lastInstantBeforeCurrentCompaction.get()).get();

When asynchronously executing archiving and compaction, due to non atomic operations here(line147-line149), although it will be determined whether it exists at line 147, there is still possible that the metafile has been archived and an exception will be throwed as ' filenotfound' when executed at line 149.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405
Copy link
Contributor

danny0405 commented Jun 14, 2023

Seems we have merged a fix already: #8783

@zhuanshenbsj1
Copy link
Contributor Author

Seems we have merged a fix already: #8783

Oh, i see. Closing this pr as #8783 has already solved the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants