Skip to content

[MINOR] Reformat HoodieAvroParquetReader #8888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 2 commits into from
Jun 6, 2023
Merged

[MINOR] Reformat HoodieAvroParquetReader #8888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c624a
[MINOR] Reformat HoodieAvroParquetReader
Zouxxyy Jun 5, 2023
59fec83
update
Zouxxyy Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieParquetInputFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public class HoodieParquetInputFormat extends HoodieParquetInputFormatBase {

private static final Logger LOG = LoggerFactory.getLogger(HoodieParquetInputFormat.class);

private boolean supportAvroRead = true;
private boolean supportAvroRead = false;

public HoodieParquetInputFormat() {
super(new HoodieCopyOnWriteTableInputFormat());
Expand Down
7 changes: 3 additions & 4 deletions hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/avro/HoodieAvroParquetReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ public class HoodieAvroParquetReader extends RecordReader<Void, ArrayWritable> {
private Schema baseSchema;

public HoodieAvroParquetReader(InputSplit inputSplit, Configuration conf) throws IOException {
AvroReadSupport avroReadSupport = new AvroReadSupport<>();
// if exists read columns, we need to filter columns.
List<String> readColNames = Arrays.asList(HoodieColumnProjectionUtils.getReadColumnNames(conf));
if (!readColNames.isEmpty()) {
Expand All @@ -66,10 +65,10 @@ public HoodieAvroParquetReader(InputSplit inputSplit, Configuration conf) throws
.filter(f -> readColNames.contains(f.name()))
.map(f -> new Schema.Field(f.name(), f.schema(), f.doc(), f.defaultVal()))
.collect(Collectors.toList()));
avroReadSupport.setAvroReadSchema(conf, filterSchema);
avroReadSupport.setRequestedProjection(conf, filterSchema);
AvroReadSupport.setAvroReadSchema(conf, filterSchema);
AvroReadSupport.setRequestedProjection(conf, filterSchema);
}
parquetRecordReader = new ParquetRecordReader<>(avroReadSupport, getFilter(conf));
parquetRecordReader = new ParquetRecordReader<>(new AvroReadSupport<>(), getFilter(conf));
}

@Override
Expand Down