[HUDI-6307] Sync TIMESTAMP_MILLIS to hive #8867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Jun 2, 2023
| @ParameterizedTest | ||
| @MethodSource("syncModeAndEnablePushDown") | ||
| public void testSyncTimestamp(String syncMode, String enablePushDown) throws Exception { | ||
| hiveSyncProps.setProperty(HIVE_SYNC_MODE.key(), syncMode); |
Contributor
There was a problem hiding this comment.
Can we add a test case similar with testSchemaConvertTimestampMicros, there is no need to add avro schema files.
danny0405
added
component:catalog-sync
Contributor
|
Hi @satishkotha can you help double check this change? I need some help for the background why in #2129 only timestamp(6) is synced as timestamp in Hive. |
Collaborator
danny0405
approved these changes
Jun 2, 2023
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Sync TIMESTAMP_MILLIS to hive
#8844 (comment)
Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist