[HUDI-6231] Handle glue comments #8740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
May 23, 2023
| private String getTableDoc() { | ||
| try { | ||
| return new TableSchemaResolver(metaClient).getTableAvroSchema(true).getDoc(); | ||
| } catch (Exception e) { |
Contributor
There was a problem hiding this comment.
Can the table avro schema be reused?
Contributor
Author
There was a problem hiding this comment.
AFAIK the avro schema is already reused by running method getTableAvroSchema ?
Contributor
|
@parisni Hi, do we have plan to push-forward this feature? |
Contributor
Author
Yes I do. I am currently in vacations |
Contributor
Author
|
@danny0405 it is aws and not gcp (about the tags changes) |
Contributor
|
Hi @parisni, I assume you have manually tested this with Glue catalog, correct? |
Contributor
Author
|
Yes we did
…On June 9, 2023 11:49:44 PM UTC, Y Ethan Guo ***@***.***> wrote:
Hi @parisni, I assume you have manually tested this with Glue catalog, correct?
--
Reply to this email directly or view it on GitHub:
#8740 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Contributor
|
Can you fix the checkstyle issue: Error: src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:[26,8] (imports) UnusedImports: Unused import - org.apache.hudi.hive.HoodieHiveSyncException.
Error: src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:[63] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - java.util.*. |
Contributor
Author
|
@danny0405 rebased master, fixed imports, and also tested locally |
Contributor
|
@hudi-bot run azure |
danny0405
approved these changes
Jun 14, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This adds the glue metastore comments feature - which was not implemented yet. Tools such athena or presto are then able to grab the comment when describe operation is done. However spark hudi won't grab them from the metastore, instead it get them from the avro schema on s3.
I don't see a way to add tests to this, since it would need a local aws stack to mimic glue
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist