Skip to content

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented May 17, 2023

Change Logs

We fixed a few issues around concurrency control that can lead to flaky tests (e.g., #8658). This PR re-enables disabled tests that are important.

Impact

Adds more test coverage.

Risk level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@yihua
Copy link
Contributor Author

yihua commented May 17, 2023

@hudi-bot run azure

@nsivabalan
Copy link
Contributor

did you trigger azure CI for 5 times may be to ensure this is not flaky anymore ?

@yihua
Copy link
Contributor Author

yihua commented May 17, 2023

did you trigger azure CI for 5 times may be to ensure this is not flaky anymore ?

Yes, in the process of triggering more runs. Currently, the CI has a long backlog, so this will take some time. Will at least run 5 times to be certain before merging this PR.

@nsivabalan
Copy link
Contributor

sg

@yihua
Copy link
Contributor Author

yihua commented May 17, 2023

@hudi-bot run azure

2 similar comments
@yihua
Copy link
Contributor Author

yihua commented May 18, 2023

@hudi-bot run azure

@yihua
Copy link
Contributor Author

yihua commented May 18, 2023

@hudi-bot run azure

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua
Copy link
Contributor Author

yihua commented May 18, 2023

CI report:

Bot commands

The fourth run failed due to other flaky tests in hudi-common and memory issue of the Azure worker. The fifth run failed due to a Spark flaky test. Both are not due to the re-enabled tests added.

@yihua yihua merged commit cfa02f2 into apache:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants