Skip to content

[HUDI-6222] ParquetSchemaConverter shoud always convert the Map key t… #8728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 1 commit into from
May 17, 2023
Merged

[HUDI-6222] ParquetSchemaConverter shoud always convert the Map key t… #8728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...k-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetSchemaConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ private static Type convertToParquetType(
.addField(
Types
.repeatedGroup()
.addField(convertToParquetType("key", keyType, repetition))
.addField(convertToParquetType("key", keyType, Type.Repetition.REQUIRED))
.addField(convertToParquetType("value", valueType, repetition))
.named("key_value"))
.named(name);
Expand Down
2 changes: 1 addition & 1 deletion ...ient/src/test/java/org/apache/hudi/io/storage/row/parquet/TestParquetSchemaConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ void testConvertComplexTypes() {
+ " }\n"
+ " optional group f_map (MAP) {\n"
+ " repeated group key_value {\n"
+ " optional int32 key;\n"
+ " required int32 key;\n"
+ " optional binary value (STRING);\n"
+ " }\n"
+ " }\n"
Expand Down