[HUDI-6212] Hudi Spark 3.0.x integration #8714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyue19921010
changed the title
zhangyue19921010
changed the title
zhangyue19921010
changed the title
| trait HoodieSpark3CatalystExpressionUtils extends HoodieCatalystExpressionUtils | ||
| with PredicateHelper { | ||
|
|
||
| override def normalizeExprs(exprs: Seq[Expression], attributes: Seq[Attribute]): Seq[Expression] = |
Contributor
Author
There was a problem hiding this comment.
DataSourceStrategy.normalizeExprs(exprs, attributes) are not included in spark3.0. So that we need to remove this specific implement in spark3-common space.
| override def normalizeExprs(exprs: Seq[Expression], attributes: Seq[Attribute]): Seq[Expression] = | ||
| DataSourceStrategy.normalizeExprs(exprs, attributes) | ||
|
|
||
| override def extractPredicatesWithinOutputSet(condition: Expression, |
Contributor
Author
There was a problem hiding this comment.
extractPredicatesWithinOutputSet are not included in spark3.0. So that we need to remove this specific implement in spark3-common space.
| case plan if !plan.resolved => None | ||
| // NOTE: When resolving Hudi table we allow [[Filter]]s and [[Project]]s be applied | ||
| // on top of it | ||
| case PhysicalOperation(_, _, DataSourceV2Relation(v2: V2TableWithV1Fallback, _, _, _, _)) if isHoodieTable(v2.v1Table) => |
Contributor
Author
There was a problem hiding this comment.
V2TableWithV1Fallback are not included in spark3.0. So that we need to remove this specific implement in spark3-common space.
| case NONE => "NONE" | ||
| case DISK_ONLY => "DISK_ONLY" | ||
| case DISK_ONLY_2 => "DISK_ONLY_2" | ||
| case DISK_ONLY_3 => "DISK_ONLY_3" |
Contributor
Author
There was a problem hiding this comment.
DISK_ONLY_3 are not included in spark3.0. So that we need to remove this specific implement in spark3-common space.
yihua
changed the title
yihua
reviewed
May 19, 2023
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/avro/TestAvroSerDe.scala
Outdated
Show resolved
Hide resolved
...park-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestMergeIntoTable.scala
Outdated
Show resolved
Hide resolved
...-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystExpressionUtils.scala
Show resolved
Hide resolved
...-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystExpressionUtils.scala
Show resolved
Hide resolved
...x/src/main/scala/org/apache/spark/sql/execution/datasources/Spark30NestedSchemaPruning.scala
Outdated
Show resolved
Hide resolved
...park3.0.x/src/main/scala/org/apache/spark/sql/hudi/Spark30ResolveHudiAlterTableCommand.scala
Outdated
Show resolved
Hide resolved
...i-spark3.0.x/src/main/scala/org/apache/spark/sql/hudi/command/Spark30AlterTableCommand.scala
Outdated
Show resolved
Hide resolved
...datasource/hudi-spark3.0.x/src/main/scala/org/apache/spark/sql/adapter/Spark3_0Adapter.scala
Show resolved
Hide resolved
yihua
changed the title
yihua
approved these changes
May 19, 2023
Contributor
|
Azure CI is green. |
zhangyue19921010
added a commit
to zhangyue19921010/hudi
that referenced
this pull request
May 20, 2023
This reverts commit 11aee96.
danny0405
reviewed
May 22, 2023
| CONFLUENT_VERSION=5.5.12 | ||
| KAFKA_CONNECT_HDFS_VERSION=10.1.13 | ||
| IMAGE_TAG=flink1146hive313spark302 | ||
| elif [[ ${SPARK_RUNTIME} == 'spark3.1.3' ]]; then |
Contributor
There was a problem hiding this comment.
Does the tag flink1146hive313spark302 needs to be prefabricated, seems no script really build this image.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Hudi spark 3.0.x adoption. Looks like we did had the support for spark3.0 in 0.9.0, and later removed it. But due to interest from the community users, we are adding it back.
Impact
Hudi spark 3.0.x adoption
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist