[HUDI-6185] Too many logs in the ExternalSpillableMap #8649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuQianJin-Stars
approved these changes
May 6, 2023
xiarixiaoyao
approved these changes
May 6, 2023
danny0405
commented
May 6, 2023
| public R put(T key, R value) { | ||
| if (this.currentInMemoryMapSize >= maxInMemorySizeInBytes || inMemoryMap.size() % NUMBER_OF_RECORDS_TO_ESTIMATE_PAYLOAD_SIZE == 0) { | ||
| long tmpEstimatedPayloadSize = (long) (this.estimatedPayloadSize * 0.9 | ||
| + (keySizeEstimator.sizeEstimate(key) + valueSizeEstimator.sizeEstimate(value)) * 0.1); |
Contributor
Author
There was a problem hiding this comment.
This line is also a mistake, because it can trigger for the 1st record with estimatedPayloadSize as 0, it then causes all the estimation of payload size far smaller than the real size.
Collaborator
Contributor
Author
|
This test is known to be flaky: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=16882&view=logs&j=dcedfe73-9485-5cc5-817a-73b61fc5dcb0&t=746585d8-b50a-55c3-26c5-517d93af9934&l=33921, would merge it soon ~ |
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
h1ap
pushed a commit
to h1ap/hudi
that referenced
this pull request
May 15, 2023
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Introduced by #6632.
The current code logs for each record when the map had been spilled. It caused deluge of loggings.
Impact
no impact
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist