[HUDI-6196] Keep compatibility for old version archival instants without ACTION_STATE field #8607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re ACTION_STATE is not present in instants.
Collaborator
danny0405
reviewed
Apr 30, 2023
| // Older files don't have action state set. | ||
| Object action = record.get(ACTION_STATE); | ||
| return record.get(ACTION_TYPE_KEY).toString().equals(HoodieTimeline.COMPACTION_ACTION) | ||
| && (action == null || HoodieInstant.State.INFLIGHT.toString().equals(action.toString())); |
Contributor
There was a problem hiding this comment.
When action equals null, the instant state is definite to be INFLIGHT for old version ? Can we write ta test case?
Member
Author
There was a problem hiding this comment.
old version is deprecated/fixed so dont know how to write unit tests for them.
Contributor
There was a problem hiding this comment.
Fine, we are good to go, I did see several issues with this in-compatibility, let's merge it first.
danny0405
reviewed
Apr 30, 2023
| record -> { | ||
| // Very old archived instants don't have action state set. | ||
| Object action = record.get(ACTION_STATE); | ||
| return action == null || HoodieInstant.State.COMPLETED.toString().equals(action.toString()); |
Contributor
There was a problem hiding this comment.
When action equals null, the instant state is definite to be COMPLETE for old version ? Can we write ta test case?
danny0405
changed the title
danny0405
approved these changes
May 10, 2023
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
…out ACTION_STATE field (apache#8607)
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
…out ACTION_STATE field (apache#8607)
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 17, 2023
…out ACTION_STATE field (apache#8607)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MINOR] Fixed the reading of instants from very old archive files where ACTION_STATE is not present in instants.
Change Logs
Ensure that ACTION_STATE exists in the record before performing the equals comparison.
Impact
Very old archive files can be read.
Risk level (write none, low medium or high below)
None
Documentation Update
None
Contributor's checklist