[MINOR] Improve documentation of org.apache.hudi.common.table.view.AbstractTableFileSystemView #8585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paddy0523
changed the title
…tractTableFileSystemView(apache#8585)
Paddy0523
changed the title
danny0405
reviewed
May 1, 2023
| * views based on that (c) Thread-safety in loading and managing file system views for this table. (d) resetting | ||
| * file-system views The actual mechanism of fetching file slices from different view storages is delegated to | ||
| * Common thread-safe implementation for multiple TableFileSystemView Implementations. <br>Provides uniform handling of: <br>(a) | ||
| * Loading file-system views from underlying file-system <br>(b) Pending compaction operations and changing file-system |
Contributor
There was a problem hiding this comment.
Maybe a <ul> list makes more sense here? The structure is:
<ul>
<li></li>
<li></li>
...
</ul>
Contributor
Author
There was a problem hiding this comment.
That's true. I made some changes
…tractTableFileSystemView with list item tag(apache#8585)
danny0405
reviewed
May 4, 2023
| * <ul> | ||
| * <li>Loading file-system views from underlying file-system</li> | ||
| * <li>Pending compaction operations and changing file-system views based on that</li> | ||
| * <li>Thread-safety in loading and managing file system views for this table</li> |
Contributor
There was a problem hiding this comment.
For each of the item, end it with ;, and for the last item, end with ..
Contributor
Author
There was a problem hiding this comment.
done, thanks for your guidance
…tractTableFileSystemView,For each of the item, end it with ;, and for the last item, end with ..(apache#8585)
danny0405
approved these changes
May 4, 2023
danny0405
changed the title
Member
|
this kind of docs update does not require CI. will just merge it. |
Contributor
Should be caution with the checkstyle error. |
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
…stractTableFileSystemView (apache#8585)
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
…stractTableFileSystemView (apache#8585)
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 17, 2023
…stractTableFileSystemView (apache#8585)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…actTableFileSystemView
Change Logs
This PR improved org.apache.hudi.common.table.view.AbstractTableFileSystemView header comments
Impact
Add the br tag to make it easier for users to understand
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist