[HUDI-6132] Fixing checkpoint management for multiple streaming writers #8558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codope
reviewed
May 1, 2023
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
Overall looks good. Minor refactoring comment.
| object HoodieStreamingSink { | ||
|
|
||
| // This constant serves as the checkpoint key for streaming sink so that each microbatch is processed exactly-once. | ||
| val SINK_CHECKPOINT_KEY = "_hudi_streaming_sink_checkpoint" |
Member
There was a problem hiding this comment.
Does it make sense to remove this object now? It's just holding a constant.
Contributor
Author
|
@codope : guess we can't define static variables within scala class and hence it has to go into the object. I would prefer to keep it in HoodieStreamingSink if you were suggesting to move it to some other class. since this is applicable only for streaming writes. |
Member
|
Sounds good. I wanted to move to write config and unify the constants for deltastreamer and spark streaming. But, now I think it makes sense to keep it separate. |
codope
approved these changes
May 2, 2023
Member
Collaborator
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
…rs (apache#8558) Each writer updates the checkpoint in commit metadata with its own batchId info only. When checking to skip the current batch, we walk back in the timeline and find the current writer's last committed batchId. Also fixed bulk insert row writer path for checkpoint management with streaming writes.
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
…rs (apache#8558) Each writer updates the checkpoint in commit metadata with its own batchId info only. When checking to skip the current batch, we walk back in the timeline and find the current writer's last committed batchId. Also fixed bulk insert row writer path for checkpoint management with streaming writes.
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 17, 2023
…rs (apache#8558) Each writer updates the checkpoint in commit metadata with its own batchId info only. When checking to skip the current batch, we walk back in the timeline and find the current writer's last committed batchId. Also fixed bulk insert row writer path for checkpoint management with streaming writes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Impact
Risk level (write none, low medium or high below)
low.
Documentation Update
N/A
Contributor's checklist