Skip to content

[HUDI-6048] Check if partition exists before list partition by path prefix #8402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codope merged 2 commits into from
Apr 14, 2023
Merged

[HUDI-6048] Check if partition exists before list partition by path prefix #8402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
994ebe9
[HUDI-6048] Check if partition exists before list partition by path p…
Zouxxyy Apr 7, 2023
99fc231
update
Zouxxyy Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...tasource/hudi-spark-common/src/main/scala/org/apache/hudi/SparkHoodieTableFileIndex.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,9 @@ class SparkHoodieTableFileIndex(spark: SparkSession,
// prefix to try to reduce the scope of the required file-listing
val relativePartitionPathPrefix = composeRelativePartitionPath(staticPartitionColumnNameValuePairs)

if (staticPartitionColumnNameValuePairs.length == partitionColumnNames.length) {
if (!metaClient.getFs.exists(new Path(getBasePath, relativePartitionPathPrefix))) {
Seq()
} else if (staticPartitionColumnNameValuePairs.length == partitionColumnNames.length) {
// In case composed partition path is complete, we can return it directly avoiding extra listing operation
Seq(new PartitionPath(relativePartitionPathPrefix, staticPartitionColumnNameValuePairs.map(_._2.asInstanceOf[AnyRef]).toArray))
} else {
Expand Down
7 changes: 6 additions & 1 deletion hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieFileIndex.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,12 @@ class TestHoodieFileIndex extends HoodieSparkClientTestBase with ScalaAssertionS
EqualTo(attribute("region_code"), literal("1"))),
"dt = '2023/01/01' and region_code = '1'",
enablePartitionPathPrefixAnalysis,
Seq(("1", "2023/01/01")))
Seq(("1", "2023/01/01"))),
// no partition matched
(Seq(EqualTo(attribute("region_code"), literal("0"))),
"region_code = '0'",
enablePartitionPathPrefixAnalysis,
Seq())
Copy link
Contributor

@danny0405 danny0405 Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the test still pass if we do not apply the fix?

Copy link
Contributor Author

@Zouxxyy Zouxxyy Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danny0405 when enableMetadataTable = false, enablePartitionPathPrefixAnalysis = true, can't pass

)

testCases.foreach(testCase => {
Expand Down