Skip to content

Conversation

@CTTY
Copy link
Contributor

@CTTY CTTY commented Mar 31, 2023

hudi-client-common and hudi-flink-client don't have any scala files yet have scala-maven-plugin specified in their pom files. It would fail when building hudi-trino-bundle with JDK 17 due the the failure below:

[ERROR] error: error while loading Object, Missing dependency 'object scala.native in compiler mirror', required by /modules/java.base/java/lang/Object.class
[ERROR] error: scala.reflect.internal.MissingRequirementError: object scala in compiler mirror not found.
[ERROR] at scala.reflect.internal.MissingRequirementError$.signal(MissingRequirementError.scala:24)
[ERROR] at scala.reflect.internal.MissingRequirementError$.notFound(MissingRequirementError.scala:25)
[ERROR] at scala.reflect.internal.Mirrors$RootsBase.$anonfun$getModuleOrClass$6(Mirrors.scala:65)
[ERROR] at scala.reflect.internal.Mirrors$RootsBase.getPackage(Mirrors.scala:65)
[ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackage$lzycompute(Definitions.scala:197)
[ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackage(Definitions.scala:197)
[ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackageClass$lzycompute(Definitions.scala:198)
[ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackageClass(Definitions.scala:198)
[ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.AnyClass$lzycompute(Definitions.scala:293)
[ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.AnyClass(Definitions.scala:293)
[ERROR] at scala.tools.nsc.symtab.classfile.ClassfileParser$ClassTypeCompleter.complete(ClassfileParser.scala:1266)
[ERROR] at scala.reflect.internal.Symbols$Symbol.info(Symbols.scala:1542)
[ERROR] at scala.reflect.internal.Symbols$Symbol.initialize(Symbols.scala:1690)
[ERROR] at scala.reflect.internal.Definitions$DefinitionsClass.init(Definitions.scala:1480)
[ERROR] at scala.tools.nsc.Global$Run.(Global.scala:1199)
[ERROR] at scala.tools.nsc.Driver.doCompile(Driver.scala:46)
[ERROR] at scala.tools.nsc.MainClass.doCompile(Main.scala:32)
[ERROR] at scala.tools.nsc.Driver.process(Driver.scala:67)
[ERROR] at scala.tools.nsc.Driver.main(Driver.scala:80)
[ERROR] at scala.tools.nsc.Main.main(Main.scala)
[ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[ERROR] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR] at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[ERROR] at scala_maven_executions.MainHelper.runMain(MainHelper.java:164)
[ERROR] at scala_maven_executions.MainWithArgsInFile.main(MainWithArgsInFile.java:26)

Change Logs

Remove scala-maven-plugin from hudi-client-common and hudi-flink-client

Impact

None

Risk level (write none, low medium or high below)

Low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@CTTY CTTY changed the title Remove unnecessary scala-maven-plugin [HUDI-6027] Remove unnecessary scala-maven-plugin Apr 3, 2023
@yihua yihua self-assigned this Apr 14, 2023
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you fix the PR description?

@yihua yihua changed the title [HUDI-6027] Remove unnecessary scala-maven-plugin [HUDI-6027] Remove unnecessary scala-maven-plugin May 6, 2023
@yihua yihua merged commit ad1b147 into apache:master May 6, 2023
@yihua yihua added the dependencies Dependency updates label May 6, 2023
yihua pushed a commit to yihua/hudi that referenced this pull request May 15, 2023
This commit removes `scala-maven-plugin` from `hudi-client-common` and `hudi-flink-client` which don't have any scala files yet have scala-maven-plugin specified in their pom files.  Without the fix it would fail when building `hudi-trino-bundle` with JDK 17.

Co-authored-by: Shawn Chang <[email protected]>
yihua pushed a commit to yihua/hudi that referenced this pull request May 15, 2023
This commit removes `scala-maven-plugin` from `hudi-client-common` and `hudi-flink-client` which don't have any scala files yet have scala-maven-plugin specified in their pom files.  Without the fix it would fail when building `hudi-trino-bundle` with JDK 17.

Co-authored-by: Shawn Chang <[email protected]>
yihua pushed a commit to yihua/hudi that referenced this pull request May 17, 2023
This commit removes `scala-maven-plugin` from `hudi-client-common` and `hudi-flink-client` which don't have any scala files yet have scala-maven-plugin specified in their pom files.  Without the fix it would fail when building `hudi-trino-bundle` with JDK 17.

Co-authored-by: Shawn Chang <[email protected]>
@CTTY CTTY deleted the ctty/remove-scala-plugin branch June 5, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency updates

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants