Skip to content

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Mar 17, 2023

Change Logs

HUDI-372 (#1054) adds support for the short name "hudi" in Spark Datasource read and write (df.write.format("hudi"), df.read.format("hudi")). All places should use "hudi" with format() now.

Impact

None. Code clean-up.

Risk level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@yihua yihua added the engine:spark Spark integration label Mar 17, 2023
@yihua yihua force-pushed the HUDI-5951-replace-format-name branch from 6a8a75c to bde163c Compare March 17, 2023 22:54
@yihua yihua force-pushed the HUDI-5951-replace-format-name branch from bde163c to 27203c2 Compare March 17, 2023 22:55
@yihua yihua changed the title [MINOR] Replace format org.apache.hudi with hudi [HUDI-5951] Replace format org.apache.hudi with short name hudi in Spark Datasource Mar 17, 2023
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Member

@codope codope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but can you check why the tests are failing?

@codope codope self-assigned this Mar 22, 2023
@yihua
Copy link
Contributor Author

yihua commented Mar 23, 2023

The change looks good but can you check why the tests are failing?

Yes, I'm going to check the CI failure.

@yihua
Copy link
Contributor Author

yihua commented Mar 31, 2023

I found out that if I replace format("org.apache.hudi") with format("hudi") in the test TestCOWDataSource.testSaveAsTableInDifferentModes fails with the following error (even without any production code changes):

java.lang.IllegalArgumentException: Insert Overwrite Partition can not use bulk insert.
	at org.apache.spark.sql.hudi.ProvidesHoodieConfig$$anonfun$9.apply(ProvidesHoodieConfig.scala:149)
	at org.apache.spark.sql.hudi.ProvidesHoodieConfig$$anonfun$9.apply(ProvidesHoodieConfig.scala:145)

We need to investigate this. Supposedly, format("hudi") is the way to go and there shouldn't be any failure.

@github-actions github-actions bot added the size:L PR with lines of changes in (300, 1000] label Feb 26, 2024
Copy link
Contributor Author

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this stale PR

@yihua yihua closed this Dec 15, 2025
@github-project-automation github-project-automation bot moved this from 🏗 Under discussion to ✅ Done in Hudi PR Support Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine:spark Spark integration size:L PR with lines of changes in (300, 1000]

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants