Skip to content

Conversation

@lvyanquan
Copy link
Contributor

@lvyanquan lvyanquan commented Feb 27, 2023

Change Logs

Remove default value for mandatory record key field.
There is a jira HUDI-4849 already before, and try to complete it.

Impact

Docs update.

Risk level (write none, low medium or high below)

low.

Documentation Update

create-table and configurations

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

the dot notation eg: `a.b.c`<br></br>
> **Default Value**: uuid (Optional)<br></br>
> **Default Value**: N/A (Required)<br></br>
> `Config Param: RECORDKEY_FIELD`<br></br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default primary key uuid is broken now?

Copy link
Contributor Author

@lvyanquan lvyanquan Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this incorrect change, this configuration has not been changed in Flink but default value 'uuid' was removed since this pr-6681 in Spark.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the other version also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked again, Default value change of 'hoodie.datasource.write.recordkey.field' was introduced only in lately release-0.13.0 and wasn't changed in release-0.12.2.
so no more versions to be fixed.

@danny0405 danny0405 merged commit e7bbd35 into apache:asf-site Feb 28, 2023
Zouxxyy pushed a commit to Zouxxyy/hudi that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants