Skip to content

Conversation

@XuQianJin-Stars
Copy link
Contributor

@XuQianJin-Stars XuQianJin-Stars commented Feb 27, 2023

Fix oom caused by addResource in flink jm building HiveSyncConfig multiple times
image
image

Change Logs

HiveSyncContext and StreamWriteOperatorCoordinator

Impact

NA

Risk level (write none, low medium or high below)

low

Documentation Update

NA

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@danny0405 danny0405 self-assigned this Feb 27, 2023
@danny0405 danny0405 added engine:flink Flink integration component:catalog-sync Catalog-sync related labels Feb 27, 2023
private static HiveSyncTool buildHiveSyncTool(Properties props, HiveConf hiveConf) {
HiveSyncTool hiveSyncTool;
HiveSyncMode syncMode = HiveSyncMode.of(props.getProperty(HIVE_SYNC_MODE.key()));
if (syncMode == HiveSyncMode.GLUE) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change.

@danny0405 danny0405 changed the title [MINOR] Fix oom caused by addResource in flink jm building HiveSyncCo… [MINOR] Release resource actively for Flink hive meta sync Feb 27, 2023
Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, nice catch ~

@danny0405 danny0405 changed the title [MINOR] Release resource actively for Flink hive meta sync [HUDI-5855] Release resource actively for Flink hive meta sync Feb 27, 2023
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit dd083c4 into apache:master Feb 27, 2023
neverdizzy pushed a commit to neverdizzy/hudi that referenced this pull request Mar 1, 2023
nsivabalan pushed a commit to nsivabalan/hudi that referenced this pull request Mar 18, 2023
nsivabalan pushed a commit to nsivabalan/hudi that referenced this pull request Mar 22, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
h1ap added a commit to h1ap/hudi that referenced this pull request Apr 12, 2023
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 20, 2023
KnightChess pushed a commit to KnightChess/hudi that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:catalog-sync Catalog-sync related engine:flink Flink integration

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants