-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-5855] Release resource actively for Flink hive meta sync #8050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a67df5 to
d37c672
Compare
danny0405
reviewed
Feb 27, 2023
| private static HiveSyncTool buildHiveSyncTool(Properties props, HiveConf hiveConf) { | ||
| HiveSyncTool hiveSyncTool; | ||
| HiveSyncMode syncMode = HiveSyncMode.of(props.getProperty(HIVE_SYNC_MODE.key())); | ||
| if (syncMode == HiveSyncMode.GLUE) { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change.
danny0405
approved these changes
Feb 27, 2023
Contributor
danny0405
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, nice catch ~
2b51bbe to
509d435
Compare
danny0405
reviewed
Feb 27, 2023
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java
Show resolved
Hide resolved
4 tasks
nsivabalan
pushed a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 18, 2023
nsivabalan
pushed a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 22, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
h1ap
pushed a commit
to h1ap/hudi
that referenced
this pull request
Apr 12, 2023
h1ap
added a commit
to h1ap/hudi
that referenced
this pull request
Apr 12, 2023
apache#8050)" This reverts commit b66023f.
h1ap
pushed a commit
to h1ap/hudi
that referenced
this pull request
Apr 12, 2023
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 20, 2023
4 tasks
KnightChess
pushed a commit
to KnightChess/hudi
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix oom caused by addResource in flink jm building HiveSyncConfig multiple times


Change Logs
HiveSyncContextandStreamWriteOperatorCoordinatorImpact
NA
Risk level (write none, low medium or high below)
low
Documentation Update
NA
Contributor's checklist