[HUDI-5731] Add guava dependency to Spark and MR bundle #7898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pan3793 first found this problem. |
KnightChess
approved these changes
Feb 8, 2023
alexeykudinkin
requested changes
Feb 8, 2023
Contributor
alexeykudinkin
left a comment
alexeykudinkin
left a comment
There was a problem hiding this comment.
Thanks for contributing @KnightChess!
I don't think this is the right solution though -- bundling guava severely exposes Hudi to potential conflicts when running environment in turn provides Guava as well
yihua
approved these changes
Feb 8, 2023
Contributor
yihua
left a comment
yihua
left a comment
There was a problem hiding this comment.
We can land this one as this brings back Guava dependencies as before such as 0.12.0 release. The shading and other issues should be tackled separately.
Contributor
|
After some discussions we agreed on following
|
alexeykudinkin
approved these changes
Feb 8, 2023
Collaborator
Contributor
|
#7900 is addressing this properly by removing unnecessary relocations |
Contributor
|
@yihua @alexeykudinkin : Should this be closed since #7900 is landed ? |
Contributor
|
@bvaradar yes, we can close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Add guava dependency to Spark and MR bundle
Impact
Configure guava relocation in Spark and MR bundle pom.xml, but there is no guava dependency, resulting in failure of guava-related class loading.
[HUDI-4482] remove guava and use caffeine instead for cache (#6240)
Risk level (write none, low medium or high below)
Documentation Update
Contributor's checklist