Skip to content

[HUDI-5678] Fix deduceShuffleParallelism in row-writing Bulk Insert helper#7818

Merged
alexeykudinkin merged 5 commits intoapache:masterfrom
jonvex:parallelism_is_zero
Feb 2, 2023
Merged

[HUDI-5678] Fix deduceShuffleParallelism in row-writing Bulk Insert helper#7818
alexeykudinkin merged 5 commits intoapache:masterfrom
jonvex:parallelism_is_zero

Conversation

@jonvex
Copy link
Copy Markdown
Contributor

@jonvex jonvex commented Feb 1, 2023

Change Logs

deduceShuffleParallelism returns 0 in some situations which should never occur.

Impact

Affects bulk insert row-writer path.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@jonvex jonvex changed the title Parallelism Issue [HUDI-5678] Parallelism Issue Feb 1, 2023
@jonvex jonvex changed the title [HUDI-5678] Parallelism Issue [HUDI-5678] deduceShuffleParallelism Returns 0 Feb 1, 2023
@alexeykudinkin alexeykudinkin added the priority:blocker Production down; release blocker label Feb 1, 2023
@alexeykudinkin alexeykudinkin self-requested a review February 1, 2023 17:26
@alexeykudinkin alexeykudinkin self-assigned this Feb 1, 2023
@alexeykudinkin alexeykudinkin changed the title [HUDI-5678] deduceShuffleParallelism Returns 0 [HUDI-5678] Fix deduceShuffleParallelism in row-writing Bulk Insert helper Feb 2, 2023
@hudi-bot
Copy link
Copy Markdown
Collaborator

hudi-bot commented Feb 2, 2023

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

|""".stripMargin)

// TODO re-enable
//assertResult(3)(spark.sql(s"select distinct _hoodie_file_name from $tableName").count())
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this has been disabled?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing currently

@jonvex will follow-up to enable it

@alexeykudinkin
Copy link
Copy Markdown
Contributor

@alexeykudinkin alexeykudinkin merged commit e3b95e8 into apache:master Feb 2, 2023
yihua pushed a commit that referenced this pull request Feb 2, 2023
… helper (#7818)

`deduceShuffleParallelism` returns 0 in some situations which should never occur.
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
… helper (apache#7818)

`deduceShuffleParallelism` returns 0 in some situations which should never occur.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants