[HUDI-5655] Closing write client for spark ds writer in all cases #7799
Merged
nsivabalan merged 1 commit intoapache:masterfrom Jan 31, 2023
Merged
[HUDI-5655] Closing write client for spark ds writer in all cases #7799nsivabalan merged 1 commit intoapache:masterfrom
nsivabalan merged 1 commit intoapache:masterfrom
Conversation
leesf
approved these changes
Jan 31, 2023
alexeykudinkin
approved these changes
Jan 31, 2023
...spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
Show resolved
Hide resolved
Collaborator
Contributor
Author
|
CI failed due to known flaky test. going ahead w/ landing. |
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
…cluding exception) (apache#7799) Looks like we miss to close the writeClient on some of the failure cases while writing via spark-ds and spark-sql writes.
yihua
pushed a commit
that referenced
this pull request
Jan 31, 2023
…cluding exception) (#7799) Looks like we miss to close the writeClient on some of the failure cases while writing via spark-ds and spark-sql writes.
nsivabalan
added a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 22, 2023
…cluding exception) (apache#7799) Looks like we miss to close the writeClient on some of the failure cases while writing via spark-ds and spark-sql writes.
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…cluding exception) (apache#7799) Looks like we miss to close the writeClient on some of the failure cases while writing via spark-ds and spark-sql writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Looks like we miss to close the writeClient on some of the failure cases while writing vis spark-ds.
Impact
Spark submit applications will exit on any failures w/ hudi. Prior to this patch, it might hung for some of the failures.
Risk level (write none, low medium or high below)
low.
Test:
Mimics hive sync failure and tested a spark submit application which writes to hudi. w/o the fix, the spark submit is just stuck. w/ this patch, spark submit completes w/ the proper stacktrace.
Documentation Update
N/A
Contributor's checklist