[HUDI-5654] Fixing reading of empty rollback completed meta files from data table timeline#7798
Merged
nsivabalan merged 1 commit intoapache:masterfrom Jan 31, 2023
Conversation
Collaborator
codope
approved these changes
Jan 31, 2023
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
Do you plan to add tests as a follow up?
Contributor
Author
Contributor
Author
|
CI failed due to known flaky test. going ahead w/ landing. |
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
…m data table timeline w/ metadata reads (apache#7798) Fixing metadata table to read rollback info even w/ empty rollback completed meta file.
yihua
pushed a commit
that referenced
this pull request
Jan 31, 2023
…m data table timeline w/ metadata reads (#7798) Fixing metadata table to read rollback info even w/ empty rollback completed meta file.
nsivabalan
added a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 22, 2023
…m data table timeline w/ metadata reads (apache#7798) Fixing metadata table to read rollback info even w/ empty rollback completed meta file.
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…m data table timeline w/ metadata reads (apache#7798) Fixing metadata table to read rollback info even w/ empty rollback completed meta file.
flashJd
pushed a commit
to flashJd/hudi
that referenced
this pull request
May 5, 2023
…m data table timeline w/ metadata reads (apache#7798) Fixing metadata table to read rollback info even w/ empty rollback completed meta file. (cherry picked from commit 5acc6fe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instant.rollback (completed rollback file) in timeline is expected to be non-empty. But in some storage systems, we could have empty files created. So, in such cases, metadata commits /read fail since we could not parse rollback commits.
Change Logs
Fixing metadata table to read rollback info even w/ empty rollback completed meta file.
Impact
No failure with metadata table.
Risk level (write none, low medium or high below)
low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist