Skip to content

[HUDI-5647] Automate savepoint and restore tests#7796

Merged
danny0405 merged 1 commit intoapache:masterfrom
danny0405:HUDI-5647
Feb 2, 2023
Merged

[HUDI-5647] Automate savepoint and restore tests#7796
danny0405 merged 1 commit intoapache:masterfrom
danny0405:HUDI-5647

Conversation

@danny0405
Copy link
Copy Markdown
Contributor

Change Logs

Add functional tests for savepoint restore.

Impact

No Impact.

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@danny0405 danny0405 added utilities engine:spark Spark integration priority:blocker Production down; release blocker labels Jan 30, 2023
@hudi-bot
Copy link
Copy Markdown
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan nsivabalan added priority:high Significant impact; potential bugs and removed priority:blocker Production down; release blocker labels Jan 31, 2023
@codope
Copy link
Copy Markdown
Member

codope commented Feb 2, 2023

@danny0405 Can you please look into the test failure?

- Test Call run_clustering Procedure By Table *** FAILED ***
  Expected Array([20230130151128302,3,REQUESTED,*], [20230130151131957,1,REQUESTED,*]), but got Array([20230130151128302,3,REQUESTED,*]) (HoodieSparkSqlTestBase.scala:106)

Copy link
Copy Markdown
Member

@codope codope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these test scenarios. I think it would be better to move other savepoint/restore tests to either one of the two test classes, e.g. testRestoreWithSavepointBeyondArchival from TestHoodieClientOnCopyOnWriteStorage.

@danny0405 danny0405 merged commit 6fbf9d4 into apache:master Feb 2, 2023
@yihua yihua added priority:blocker Production down; release blocker and removed priority:high Significant impact; potential bugs labels Feb 5, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine:spark Spark integration priority:blocker Production down; release blocker

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants