[HUDI-5638] Fix metaserver test setup #7785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yihua
reviewed
Jan 29, 2023
| BUILD_PROFILES: '-Dscala-2.11 -Dspark2.4 -Dflink1.16' | ||
| PLUGIN_OPTS: '-Dcheckstyle.skip=true -Drat.skip=true -Djacoco.skip=true -ntp -B -V -Pwarn-log -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=warn -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.dependency=warn' | ||
| MVN_OPTS_INSTALL: '-DskipTests $(BUILD_PROFILES) $(PLUGIN_OPTS)' | ||
| MVN_OPTS_INSTALL: '-Phudi-platform-service -DskipTests $(BUILD_PROFILES) $(PLUGIN_OPTS)' |
Contributor
There was a problem hiding this comment.
Shall we include this module by default? We already have enough profiles and let's not add a new one.
Contributor
There was a problem hiding this comment.
Synced offline. This is due to the limitation of Thrift code generation. We have to live with it now.
yihua
approved these changes
Jan 29, 2023
| BUILD_PROFILES: '-Dscala-2.11 -Dspark2.4 -Dflink1.16' | ||
| PLUGIN_OPTS: '-Dcheckstyle.skip=true -Drat.skip=true -Djacoco.skip=true -ntp -B -V -Pwarn-log -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=warn -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.dependency=warn' | ||
| MVN_OPTS_INSTALL: '-DskipTests $(BUILD_PROFILES) $(PLUGIN_OPTS)' | ||
| MVN_OPTS_INSTALL: '-Phudi-platform-service -DskipTests $(BUILD_PROFILES) $(PLUGIN_OPTS)' |
Contributor
There was a problem hiding this comment.
Synced offline. This is due to the limitation of Thrift code generation. We have to live with it now.
yihua
pushed a commit
that referenced
this pull request
Jan 30, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
Fix tests and artifact deployment for metaserver.
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Fix tests and artifact deployment for metaserver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
hudi-platform-serviceprofile activated under-DdeployArtifactsImpact
Fix tests and artifact deployment for metaserver.
Risk level
Medium.
Documentation Update
NA
Contributor's checklist