Skip to content

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Jan 28, 2023

Change Logs

The scripts/release/validate_staged_release.sh throws the following error

Checking for binary files in source release
There were non-text files in source release. [ERROR]
 Please check below

./release/release_guide_overview.jpg: image/png; charset=binary


Performing custom Licensing Check 
There were some source files that did not have Apache License [ERROR]
./release/release_guide_overview.jpg

This PR fixes scripts/release/validate_staged_release.sh to skip checking release/release_guide* for "Binary Files Check" and "Licensing Check".

Impact

Fixes the "Binary Files Check" and "Licensing Check" for release candidates.

Risk level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@yihua yihua added the priority:blocker Production down; release blocker label Jan 28, 2023
@yihua yihua merged commit aebe3cc into apache:master Jan 28, 2023
yihua added a commit that referenced this pull request Jan 28, 2023
This commit fixes `scripts/release/validate_staged_release.sh` to skip checking `release/release_guide*` for "Binary Files Check" and "Licensing Check".
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Jan 31, 2023
This commit fixes `scripts/release/validate_staged_release.sh` to skip checking `release/release_guide*` for "Binary Files Check" and "Licensing Check".
nsivabalan pushed a commit to nsivabalan/hudi that referenced this pull request Mar 22, 2023
This commit fixes `scripts/release/validate_staged_release.sh` to skip checking `release/release_guide*` for "Binary Files Check" and "Licensing Check".
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
This commit fixes `scripts/release/validate_staged_release.sh` to skip checking `release/release_guide*` for "Binary Files Check" and "Licensing Check".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants