Skip to content

Conversation

@codope
Copy link
Member

@codope codope commented Jan 28, 2023

Change Logs

Enable schema reconciliation by default as commit should go through with the wider schema in case of conflict.

Impact

Schema will be reconciled by default.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@codope codope added area:schema Schema evolution and data types priority:blocker Production down; release blocker labels Jan 28, 2023
@danny0405
Copy link
Contributor

@codope I think we should create a JIRA issue for it.

@codope codope changed the title Enable schema reconciliation by default [HUDI-4071] Enable schema reconciliation by default Jan 28, 2023
@codope codope changed the title [HUDI-4071] Enable schema reconciliation by default [HUDI-5642] Enable schema reconciliation by default Jan 29, 2023
@codope
Copy link
Member Author

codope commented Jan 29, 2023

The test failures are due to SchemaCompatibiltyException. One thing to note is that for an incoming schema with compatible projection of the latest table schema, the table schema is chosen but it may lose any data type promotion. See

if (isCompatibleProjectionOf(tableSchema, newSchema)) {
// Picking table schema as a writer schema we need to validate that we'd be able to
// rewrite incoming batch's data (written in new schema) into it
(tableSchema, isSchemaCompatible(newSchema, tableSchema))
} else {
// Picking new schema as a writer schema we need to validate that we'd be able to
// rewrite table's data into it
(newSchema, isSchemaCompatible(tableSchema, newSchema))
}

@codope codope added priority:critical Production degraded; pipelines stalled and removed priority:blocker Production down; release blocker labels Jan 30, 2023
@vinothchandar
Copy link
Member

@codope please help me understand why this is critical priority?

@codope codope added priority:high Significant impact; potential bugs and removed priority:critical Production degraded; pipelines stalled labels Apr 26, 2023
@codope
Copy link
Member Author

codope commented Apr 26, 2023

please help me understand why this is critical priority?

this was planned to be done in one of the prev releases but there are some issues. I've lowered the priority for now, but we should take it up for 0.14.0. Updated the fix version on JIRA appropriately.

@hudi-bot
Copy link
Collaborator

hudi-bot commented Jul 6, 2023

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405
Copy link
Contributor

this was planned to be done in one of the prev releases but there are some issues. I've lowered the priority for now, but we should take it up for 0.14.0. Updated the fix version on JIRA appropriately.

That's cool, but we are not expecting to introduce any schema data type related regressions.

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Feb 26, 2024
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config is deprecated after #9743, so closing this stale PR.

@yihua yihua closed this Dec 14, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Hudi PR Support Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:schema Schema evolution and data types priority:high Significant impact; potential bugs size:XS PR with lines of changes in <= 10

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants