Skip to content

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Jan 28, 2023

Change Logs

This PR fix the release scripts:

  • cut_release_branch.sh: git push to master is no longer allowed. Any commit to merge to master needs approval from a committer. So git push origin ${MASTER_BRANCH} is removed from the script. A new branch is created for the version upgrade on the master, and the script prompts the release manager to manually open a PR for this.
  • deploy_staging_jars.sh: Previously, both mvn commands for each profile run tests and upload the jars to the staging area, which is a waste of time. This issue is fixed in this PR. Also, adjusts the profiles to add hudi-cli-bundle.
  • validate_staged_bundles.sh: Adds new bundles generated.

Impact

Makes sure the scripts run smoothly, efficiently, up to date based on the new bundles.

Risk level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@yihua yihua added the priority:blocker Production down; release blocker label Jan 28, 2023
@yihua yihua requested a review from xushiyan January 28, 2023 08:01
@yihua yihua force-pushed the HUDI-5635-fix-release-scripts branch 2 times, most recently from 849b9bb to 64a2c1d Compare January 28, 2023 08:08
@yihua yihua force-pushed the HUDI-5635-fix-release-scripts branch from 64a2c1d to 7db6c47 Compare January 28, 2023 08:19
Comment on lines 106 to 105
$MVN install "$COMMON_OPTIONS" "${v}"
$MVN install -DskipTests ${v}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double check if integ test module will be skipped or not

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit 50b2cb5 into apache:master Jan 28, 2023
yihua added a commit that referenced this pull request Jan 28, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Jan 31, 2023
nsivabalan pushed a commit to nsivabalan/hudi that referenced this pull request Mar 22, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants