[HUDI-5631] Improve defaults of early conflict detection configs #7770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
added
priority:blocker
nsivabalan
force-pushed
the
HUDI-5631-ecd-defaults
branch
from
acff503 to
ab0d70b
Compare
Contributor
|
rebased w/ latest master |
xushiyan
approved these changes
Jan 28, 2023
zhangyue19921010
approved these changes
Jan 28, 2023
Contributor
zhangyue19921010
left a comment
zhangyue19921010
left a comment
There was a problem hiding this comment.
Will land this pr after CI passed.
yihua
added a commit
that referenced
this pull request
Jan 30, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR improves the defaults of early conflict detection configs:
async.conflict.detector.initial_delay_ms: 30,000 -> 0maxAllowableHeartbeatIntervalInMsfor early conflict detection at the timeline server: 60,000 -> 120,000 to be aligned with existing heartbeat timeoutThis PR also fixes a bug in
EmbeddedTimelineServiceto set the correctmaxAllowableHeartbeatIntervalInMsfor early conflict detection.Impact
Gives better defaults for early conflict detection out of the box.
Risk level
low
Documentation Update
The defaults of the configs will be automatically updated on the Hudi website once the release docs are updated.
Contributor's checklist