Skip to content

Conversation

@nsivabalan
Copy link
Contributor

Change Logs

Fixing flaky parquet projection tests. Added 10% margin for expected bytes from col projection.

Impact

Stable CI

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

Copy link
Member

@xushiyan xushiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable other skipped cases? those set to -1

@nsivabalan nsivabalan added the priority:blocker Production down; release blocker label Jan 28, 2023
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan
Copy link
Contributor Author

Failed due to a flaky deltastreamer test. going ahead to unblock other blocker patches

@nsivabalan nsivabalan merged commit 67d661c into apache:master Jan 28, 2023
yihua pushed a commit that referenced this pull request Jan 30, 2023
Fixing flaky parquet projection tests. Added 10% margin for expected bytes from col projection.
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Jan 31, 2023
Fixing flaky parquet projection tests. Added 10% margin for expected bytes from col projection.
nsivabalan added a commit to nsivabalan/hudi that referenced this pull request Mar 22, 2023
Fixing flaky parquet projection tests. Added 10% margin for expected bytes from col projection.
package org.apache.hudi.functional

import org.apache.avro.Schema
import org.apache.calcite.runtime.SqlFunctions.abs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't Math.abs be sufficient?

fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Fixing flaky parquet projection tests. Added 10% margin for expected bytes from col projection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants