[HUDI-5628] Fixing log record reader scan V2 config name #7764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@hudi-bot run azure |
nsivabalan
force-pushed
the
logRecordReaderConfigNameFix
branch
from
ebcae89 to
27109ab
Compare
xushiyan
reviewed
Jan 28, 2023
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java
Outdated
Show resolved
Hide resolved
danny0405
reviewed
Jan 28, 2023
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java
Show resolved
Hide resolved
danny0405
reviewed
Jan 28, 2023
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
Show resolved
Hide resolved
xushiyan
reviewed
Jan 28, 2023
hudi-cli/src/main/java/org/apache/hudi/cli/commands/HoodieLogFileCommand.java
Outdated
Show resolved
Hide resolved
danny0405
reviewed
Jan 28, 2023
| .withRecordMerger(HoodieRecordUtils.loadRecordMerger(HoodieAvroRecordMerger.class.getName())) | ||
| .withUseScanV2(Boolean.parseBoolean(HoodieCompactionConfig.USE_LOG_RECORD_READER_SCAN_V2.defaultValue())) | ||
| .withEnableOptimizedLogBlocksScan(Boolean.parseBoolean(HoodieCompactionConfig.ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN.defaultValue())) | ||
| .build(); |
xushiyan
approved these changes
Jan 28, 2023
nsivabalan
force-pushed
the
logRecordReaderConfigNameFix
branch
from
1ca4c0e to
a950598
Compare
Contributor
Author
|
CI failed due to known flaky tests. |
1 similar comment
Contributor
Author
|
CI failed due to known flaky tests. |
yihua
pushed a commit
that referenced
this pull request
Jan 30, 2023
We introduced a new way to scan log blocks in LogRecordReader and have named it as "hoodie.log.record.reader.use.scanV2". Fixing the config name to be elegant: "hoodie.optimized.log.blocks.scan.enable". Fixing the corresponding Metadata config as well.
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
We introduced a new way to scan log blocks in LogRecordReader and have named it as "hoodie.log.record.reader.use.scanV2". Fixing the config name to be elegant: "hoodie.optimized.log.blocks.scan.enable". Fixing the corresponding Metadata config as well.
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
We introduced a new way to scan log blocks in LogRecordReader and have named it as "hoodie.log.record.reader.use.scanV2". Fixing the config name to be elegant: "hoodie.optimized.log.blocks.scan.enable". Fixing the corresponding Metadata config as well.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
We introduced a new way to scan log blocks in LogRecordReader and have named it as "hoodie.log.record.reader.use.scanV2". Fixing the config name to be elegant: "hoodie.optimized.log.blocks.scan.enable". Metadata config also has an entry for the same. So, fixing that as well.
Impact
Good/Understandable config names.
Risk level (write none, low medium or high below)
no.
Documentation Update
Config docs will automatically be generated during release.
Contributor's checklist