Skip to content

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Jan 27, 2023

Change Logs

This PR improves the usability of Hudi CLI bundle by changing hudi-cli-with-bundle.sh:

  • Adds the ability to specify existing hudi-cli-bundle and hudi-spark-bundle jars downloaded by user, through environmental variables CLI_BUNDLE_JAR and SPARK_BUNDLE_JAR. Currently it assumes that these jars are built inside Hudi repo and there is no way to specify the jars from another path.
  • Automatically downloads the auxiliary jars to auxlib/ for Hudi CLI. Right now, Hudi CLI bundle still requires additional org.glassfish:jakarta.el and jakarta.el:jakarta.el-api jars in the Java classpath to start the Hudi CLI shell. Auto-downloads make it easier for the users.

Impact

Makes hudi-cli-with-bundle.sh easier to start Hudi CLI shell.

This is tested locally on Spark 3.3. The Hudi CLI shell can start without any problem.

Risk level

low

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@yihua yihua added priority:blocker Production down; release blocker cli labels Jan 27, 2023
@rahil-c
Copy link
Collaborator

rahil-c commented Jan 27, 2023

LGTM

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit a62f0f6 into apache:master Jan 27, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Jan 31, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants