[HUDI-5626] Rename CDC logging mode options #7760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Jan 27, 2023
| .stringType() | ||
| .defaultValue("cdc_data_before_after") // default record all the change log images | ||
| .defaultValue(op_key_only.name()) | ||
| .withFallbackKeys(HoodieTableConfig.CDC_SUPPLEMENTAL_LOGGING_MODE.key()) |
Contributor
There was a problem hiding this comment.
Let's keep the default value of Flink as data_before_after, there are some issues maybe for the other 2 modes because Flink can trigger eager flush, the intermediate data file may cause changes loss, we can switch to other modes when I fix that.
Member
Author
There was a problem hiding this comment.
@danny0405 do you have jira to track this work? i'd link it from the code as todo
Contributor
There was a problem hiding this comment.
Just create one: https://issues.apache.org/jira/browse/HUDI-5636
xushiyan
changed the title
YannByron
approved these changes
Jan 28, 2023
nsivabalan
force-pushed
the
minor-update-cdc-config
branch
from
846574a to
177e797
Compare
Contributor
|
rebased w/ lastest master |
Collaborator
yihua
pushed a commit
that referenced
this pull request
Jan 30, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
Change logging mode names for CDC feature to - op_key_only - data_before - data_before_after
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Change logging mode names for CDC feature to - op_key_only - data_before - data_before_after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Change logging mode names to
op_key_onlydata_beforedata_before_afterImpact
Config name changes. No impact as it's done before 0.13 release.
Risk level
None.
Documentation Update
NA
Contributor's checklist